gauge: fade-in cells land on the new cell; skin-set clear mark offset #15

Closed
GanYiZhong wants to merge 1 commits from GanYiZhong/PyTaikoGreen:fix/gauge-fade-in-cell into main
pull from: GanYiZhong/PyTaikoGreen:fix/gauge-fade-in-cell
Contributor

Since 47319061, skins with gauge_cell_fade_in draw their gauge wrong (Nijiiro):

  • Gap before the new cell. The gauge-up sprite moved to length * bw ("glow rides the leading edge"). That's right for a flash glow, but with gauge_cell_fade_in the sprite is the new cell, and the fill stops at length - 1 until it lands. So the cell fades in one cell too far right, and the cell before it stays dark until the animation ends.
  • Clear mark off the cell grid. The clear mark moved to the exact fraction minus units / 60 cells. That matches Green's 87-cell art, but on Nijiiro's 50 × 21 px grid it puts the gold zone and the clear cap 3.5 px off the cell edges and the クリア frame.

Changes:

  • With gauge_cell_fade_in, the sprite goes back to the new cell ((length - 1) * bw). Flash skins keep length * bw.
  • New optional skin_config gauge_clear_mark_offset (cells): how far before the exact clear fraction the mark sits. Unset, it stays units / 60, so Green draws exactly as now. Nijiiro will set it to 1, which gives back its cell-aligned mark (cpx = clear_point - 1, identical to the layout before 47319061).

Checked on Nijiiro, Hard (Chouchou, auto), frame by frame around a gauge gain: the new cell now fades in right after the fill with no gap, and the gold zone starts at the クリア frame edge (x 1452 instead of 1455).

🤖 Generated with Claude Code

Since 47319061, skins with `gauge_cell_fade_in` draw their gauge wrong (Nijiiro): - **Gap before the new cell.** The gauge-up sprite moved to `length * bw` ("glow rides the leading edge"). That's right for a flash glow, but with `gauge_cell_fade_in` the sprite *is* the new cell, and the fill stops at `length - 1` until it lands. So the cell fades in one cell too far right, and the cell before it stays dark until the animation ends. - **Clear mark off the cell grid.** The clear mark moved to the exact fraction minus `units / 60` cells. That matches Green's 87-cell art, but on Nijiiro's 50 × 21 px grid it puts the gold zone and the clear cap 3.5 px off the cell edges and the クリア frame. Changes: - With `gauge_cell_fade_in`, the sprite goes back to the new cell (`(length - 1) * bw`). Flash skins keep `length * bw`. - New optional skin_config `gauge_clear_mark_offset` (cells): how far before the exact clear fraction the mark sits. Unset, it stays `units / 60`, so Green draws exactly as now. Nijiiro will set it to 1, which gives back its cell-aligned mark (`cpx = clear_point - 1`, identical to the layout before 47319061). Checked on Nijiiro, Hard (Chouchou, auto), frame by frame around a gauge gain: the new cell now fades in right after the fill with no gap, and the gold zone starts at the クリア frame edge (x 1452 instead of 1455). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
GanYiZhong added 1 commit 2026-10-14 03:54:31 +02:00
Author
Contributor

Closing: this is Nijiiro-specific, so it will be handled in the Nijiiro skin instead.

Closing: this is Nijiiro-specific, so it will be handled in the Nijiiro skin instead.
GanYiZhong closed this pull request 2026-10-14 04:02:41 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Yonokid/PyTaikoGreen#15