Adds the skin config keys for the engine PR that makes the big-note firework configurable (Yonokid/YataiDON, "Big-note firework: count, timing, path and scale from skin config").
note_arc_firework_spawn: the first spark's frame (x), the frames between sparks (y) and how many there are (width).
note_arc_firework_path: where each spark sits on the note's arc, in frames of the flight (x for the first, then y apart).
note_arc_firework_scale: the spark's scale (x).
screen.options.note_arc_firework_cabinet (default false): sparks centred on the note, drawn additively, and only behind hit big don/ka.
The values are what the engine does now (6 sparks from frame 6, 3 apart, at 0.8), so nothing changes for this skin.
Also, for the flight shape (same engine PR):
note_arc_frames (x): how many frames the flight takes. 31, as now.
note_arc_cubic_control: the cubic arc's control points, as offsets from the start (x, y) and from the end (width, height), and note_arc_cubic_control_p2 the same for P2. Unused here.
Adds the skin config keys for the engine PR that makes the big-note firework configurable (Yonokid/YataiDON, "Big-note firework: count, timing, path and scale from skin config").
- `note_arc_firework_spawn`: the first spark's frame (`x`), the frames between sparks (`y`) and how many there are (`width`).
- `note_arc_firework_path`: where each spark sits on the note's arc, in frames of the flight (`x` for the first, then `y` apart).
- `note_arc_firework_scale`: the spark's scale (`x`).
- `screen.options.note_arc_firework_cabinet` (default `false`): sparks centred on the note, drawn additively, and only behind hit big don/ka.
The values are what the engine does now (6 sparks from frame 6, 3 apart, at 0.8), so nothing changes for this skin.
Also, for the flight shape (same engine PR):
- `note_arc_frames` (`x`): how many frames the flight takes. 31, as now.
- `note_arc_cubic_control`: the cubic arc's control points, as offsets from the start (`x`, `y`) and from the end (`width`, `height`), and `note_arc_cubic_control_p2` the same for P2. Unused here.
- `screen.options.note_arc_cubic` (default `false`).
🤖 Generated with [Claude Code](https://claude.com/claude-code)
The values are the engine's current behaviour (6 sparks from frame 6, 3 apart, at 0.8), so nothing changes for this skin.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closing: note arcs are drawn in Lua now (YataiDON 93f62e5), so these keys aren't needed. The cabinet arc and sparks will live in Nijiiro's own note_arc.lua.
Closing: note arcs are drawn in Lua now (YataiDON 93f62e5), so these keys aren't needed. The cabinet arc and sparks will live in Nijiiro's own note_arc.lua.
Pull request closed
Please reopen this pull request to perform a merge.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Adds the skin config keys for the engine PR that makes the big-note firework configurable (Yonokid/YataiDON, "Big-note firework: count, timing, path and scale from skin config").
note_arc_firework_spawn: the first spark's frame (x), the frames between sparks (y) and how many there are (width).note_arc_firework_path: where each spark sits on the note's arc, in frames of the flight (xfor the first, thenyapart).note_arc_firework_scale: the spark's scale (x).screen.options.note_arc_firework_cabinet(defaultfalse): sparks centred on the note, drawn additively, and only behind hit big don/ka.The values are what the engine does now (6 sparks from frame 6, 3 apart, at 0.8), so nothing changes for this skin.
Also, for the flight shape (same engine PR):
note_arc_frames(x): how many frames the flight takes. 31, as now.note_arc_cubic_control: the cubic arc's control points, as offsets from the start (x,y) and from the end (width,height), andnote_arc_cubic_control_p2the same for P2. Unused here.screen.options.note_arc_cubic(defaultfalse).🤖 Generated with Claude Code
Closing: note arcs are drawn in Lua now (YataiDON 93f62e5), so these keys aren't needed. The cabinet arc and sparks will live in Nijiiro's own note_arc.lua.
Pull request closed