Ending: place the 2P banner on the 2P lane (game_p2_y) #38

2026-09-28T23:57:34+02:00

GanYiZhong commented

2026-09-28 23:57:34 +02:00

In two-player games the 2P clear / full combo / fail banner never showed: Ending.new placed it at STAGE_Y + game_2p_offset, but game_2p_offset is the distance between the two background bands (536 in Green's 1280 space, 804 at 1920), not between the lanes, so the 2P banner was drawn below the bottom of the screen.

The 2P lane is at game_p2_y and the 1P lane at 184 (both × screen scale, as the engine draws them), so the 2P banner now sits game_p2_y − 184·scale below the 1P one (264 px at 1920×1080). Only Scripts/background/bg_objects/ending.lua changes; the other game_2p_offset readers (donbg bands, chibis) are background bands and stay as they are.

Checked with a two-player auto-play: the 2P banner shows on the 2P lane.

🤖 Generated with Claude Code

In two-player games the 2P clear / full combo / fail banner never showed: `Ending.new` placed it at `STAGE_Y + game_2p_offset`, but `game_2p_offset` is the distance between the two background bands (536 in Green's 1280 space, 804 at 1920), not between the lanes, so the 2P banner was drawn below the bottom of the screen. The 2P lane is at `game_p2_y` and the 1P lane at 184 (both × screen scale, as the engine draws them), so the 2P banner now sits `game_p2_y − 184·scale` below the 1P one (264 px at 1920×1080). Only `Scripts/background/bg_objects/ending.lua` changes; the other `game_2p_offset` readers (donbg bands, chibis) are background bands and stay as they are. Checked with a two-player auto-play: the 2P banner shows on the 2P lane. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

GanYiZhong added 1 commit 2026-09-28 23:57:35 +02:00

Ending: place the 2P banner on the 2P lane (game_p2_y) 2ab127b8b3

game_2p_offset is the distance between the two background bands (536), not between the lanes,
so in two-player games the 2P clear / full combo / fail banner was drawn below the screen.
The 2P lane is at game_p2_y, the 1P lane at 184 (both x screen scale).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Yonokid merged commit 1c14110802 into main

2026-09-29 16:49:52 +02:00

Yonokid referenced this issue from a commit

2026-10-04 07:13:41 +02:00

Merge pull request 'Ending: place the 2P banner on the 2P lane (game_p2_y)' (#38) from GanYiZhong/YataiDONNijiiro:fix/2p-ending-lane-y into main

Yonokid referenced this issue from a commit

2026-10-04 07:19:52 +02:00

Merge pull request 'Ending: place the 2P banner on the 2P lane (game_p2_y)' (#38) from GanYiZhong/YataiDONNijiiro:fix/2p-ending-lane-y into main

Sign in to join this conversation.