Animations: follow the engine's merged move animations #39

2026-09-29T18:41:52+02:00

GanYiZhong commented

2026-09-29 18:41:52 +02:00

Engine commit cf785cf ("simplify some animations") merged several move animations into one each, and removed the single waypoint key. PyTaikoGreen's animation.json was updated to match, but this skin still had the old definitions. The engine now reads them with a different meaning, so for example the add-score digits jump to the wrong height and never fan out.

Converted at this skin's own values, so the motion is the same as before the engine change:

kusudama 11 = old 11 + 12, 13 = old 13 + 18 (14's delay now references 11 only)
diff sort confirmation bounce 22 = old 22–25
score counter: 38 = y before the fan-out (the old start y 222, then old 39), 39 = fan-out (old 40)
song_select / dan_select 28 / 39: waypoint + waypoint_at → waypoints: [{at, value}]

Removed ids: 12, 18, 40 (game) and 23–25 (song_select). Nothing else references them.

🤖 Generated with Claude Code

Engine commit cf785cf ("simplify some animations") merged several move animations into one each, and removed the single `waypoint` key. PyTaikoGreen's animation.json was updated to match, but this skin still had the old definitions. The engine now reads them with a different meaning, so for example the add-score digits jump to the wrong height and never fan out. Converted at this skin's own values, so the motion is the same as before the engine change: - kusudama `11` = old 11 + 12, `13` = old 13 + 18 (`14`'s delay now references 11 only) - diff sort confirmation bounce `22` = old 22–25 - score counter: `38` = y before the fan-out (the old start y 222, then old 39), `39` = fan-out (old 40) - song_select / dan_select `28` / `39`: `waypoint` + `waypoint_at` → `waypoints: [{at, value}]` Removed ids: 12, 18, 40 (game) and 23–25 (song_select). Nothing else references them. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

GanYiZhong added 1 commit 2026-09-29 18:41:54 +02:00

Animations: follow the engine's merged move animations (cf785cf) 68ab2a311e

The engine now reads one move per effect where it used to add several:
kusudama 11 (= old 11 + 12) and 13 (= old 13 + 18), diff sort bounce 22
(= old 22-25), score counter 38 (y before the fan-out, from the old start
y and 39) and 39 (fan-out = old 40); the single-point "waypoint" key is
now a "waypoints" list. Same motion as before, at this skin's values.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Yonokid added 1 commit 2026-09-30 21:53:43 +02:00

Merge branch 'main' into fix/merged-move-animations afa111e474

Yonokid merged commit 88795d175e into main

2026-09-30 21:54:19 +02:00

Yonokid referenced this issue from a commit

2026-10-04 07:13:41 +02:00

Merge pull request 'Animations: follow the engine's merged move animations' (#39) from GanYiZhong/YataiDONNijiiro:fix/merged-move-animations into main

Yonokid referenced this issue from a commit

2026-10-04 07:19:52 +02:00

Merge pull request 'Animations: follow the engine's merged move animations' (#39) from GanYiZhong/YataiDONNijiiro:fix/merged-move-animations into main

Sign in to join this conversation.