Background: the collab backgrounds PyTaikoGreen added after background.lua was forked #40

Merged
Yonokid merged 3 commits from GanYiZhong/YataiDONNijiiro:fix/collab-backgrounds into main 2026-09-30 21:55:00 +02:00
Collaborator

This skin's background.lua was forked from PyTaikoGreen on 2026-09-02. PyTaikoGreen then added DQ10 (09-07) and 26 more collab backgrounds (09-09, "Add all missing collab backgrounds"). A chart with SCENEPRESET:MIKU, TOHO, YOKAI, ... therefore fell back to the standard background here.

  • background.lua: adds those 27 entries to COLLABS, using PyTaikoGreen's modules (require falls back to the parent's Scripts). The existing 10 entries and the 1P-only rule are unchanged.
  • bg_collabs/gumi.lua: PyTaikoGreen's module, with GumiDonBG filling in the fields PyTaikoGreen's DonBG6 sets (overlay_1_texture ...). This skin has its own donbg/6, and without those fields GUMI's draw_textures raised a Lua error every frame.

Tested all 37 presets on this skin (auto play, SCENEPRESET:<name> on the same chart): each shows its collab background with no Lua errors. The only error lines left are the existing No textures loaded for .../fever_0 probes (fever.lua asks for optional overlay_l / overlay_r), which also appear on PyTaikoGreen.

🤖 Generated with Claude Code

This skin's `background.lua` was forked from PyTaikoGreen on 2026-09-02. PyTaikoGreen then added DQ10 (09-07) and 26 more collab backgrounds (09-09, "Add all missing collab backgrounds"). A chart with `SCENEPRESET:MIKU`, `TOHO`, `YOKAI`, ... therefore fell back to the standard background here. - `background.lua`: adds those 27 entries to `COLLABS`, using PyTaikoGreen's modules (`require` falls back to the parent's Scripts). The existing 10 entries and the 1P-only rule are unchanged. - `bg_collabs/gumi.lua`: PyTaikoGreen's module, with `GumiDonBG` filling in the fields PyTaikoGreen's `DonBG6` sets (`overlay_1_texture` ...). This skin has its own `donbg/6`, and without those fields GUMI's `draw_textures` raised a Lua error every frame. Tested all 37 presets on this skin (auto play, `SCENEPRESET:<name>` on the same chart): each shows its collab background with no Lua errors. The only error lines left are the existing `No textures loaded for .../fever_0` probes (fever.lua asks for optional `overlay_l` / `overlay_r`), which also appear on PyTaikoGreen. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
GanYiZhong added 1 commit 2026-09-29 19:31:16 +02:00
background.lua was forked from PyTaikoGreen on 2026-09-02; PyTaikoGreen then
added DQ10 (09-07) and 26 more (09-09, "Add all missing collab
backgrounds"), so a chart with SCENEPRESET:MIKU / TOHO / YOKAI / ... fell
back to the standard background here. They now use PyTaikoGreen's modules.

bg_collabs/gumi.lua: PyTaikoGreen's, with GumiDonBG filling in the fields
PyTaikoGreen's DonBG6 sets (this skin has its own donbg/6), which its
draw_textures uses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Yonokid added 1 commit 2026-09-30 21:54:00 +02:00
Yonokid added 1 commit 2026-09-30 21:54:48 +02:00
Yonokid merged commit 18f674147e into main 2026-09-30 21:55:00 +02:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Yonokid/YataiDONNijiiro#40