Add yellow_box_bottom to skin_config (dan select box bottom edge) #41

2026-10-02T01:26:09+02:00

GanYiZhong commented

2026-10-02 01:26:09 +02:00

Since YataiDON d60791d the dan select yellow box reads its bottom edge from the skin_config key yellow_box_bottom instead of the yellow_box_bottom_right texture's y. Nijiiro doesn't define the key, so the bottom row is placed by the fallback and the box looks cut off under the song scrolls.

This adds yellow_box_bottom: {y: 974}, the value the texture entry used.

🤖 Generated with Claude Code

Since YataiDON d60791d the dan select yellow box reads its bottom edge from the skin_config key `yellow_box_bottom` instead of the `yellow_box_bottom_right` texture's y. Nijiiro doesn't define the key, so the bottom row is placed by the fallback and the box looks cut off under the song scrolls. This adds `yellow_box_bottom: {y: 974}`, the value the texture entry used. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

GanYiZhong added 1 commit 2026-10-04 19:36:39 +02:00

skin_config: add yellow_box_bottom for the dan select box 3be0239090

The engine now reads the yellow box's bottom edge from skin_config
yellow_box_bottom instead of the yellow_box_bottom_right texture's y.
Without the key the bottom row was placed by the fallback and the box
looked cut off under the song scrolls. 974 is the value the texture
entry used.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

GanYiZhong force-pushed fix/yellow-box-bottom from 0ac6ff0aeb to 3be0239090

2026-10-04 19:36:39 +02:00

Compare

Yonokid added 1 commit 2026-10-05 13:46:00 +02:00

Merge branch 'main' into fix/yellow-box-bottom b87ef7a172

Yonokid merged commit fafd8d2778 into main

2026-10-05 13:46:09 +02:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Yonokid/YataiDONNijiiro#41

Allow edits from maintainers