Yonokid/YataiDONNijiiro
1
0 Fork 1
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

dan select: extend the parent's DanSelect instead of replacing it #42

Merged
Yonokid merged 2 commits from GanYiZhong/YataiDONNijiiro:fix/dan-select-parent into main 2026-10-05 13:48:44 +02:00
Conversation 0 Commits 2 Files Changed 1
+29 -8
GanYiZhong commented 2026-10-02 19:41:32 +02:00
Collaborator
Copy link
Copy source

The dan boxes moved to PyTaikoGreen's Scripts/dan_select/dan_select.lua. This skin's own dan_select.lua (cursor/arrow clips only) shadowed it, so the dan select showed no dan boxes at all.

It now loads the parent skin's dan_select/dan_select.lua first (the next match on package.path after this file) and adds only the clip-sampled draw_cursor on top; without clip data the engine's inline cursor is used as before. Future changes to the parent's dan box drawing carry over automatically.

Tested: the dan ribbon, open dan box and exam panel draw again.

🤖 Generated with Claude Code

The dan boxes moved to PyTaikoGreen's `Scripts/dan_select/dan_select.lua`. This skin's own `dan_select.lua` (cursor/arrow clips only) shadowed it, so the dan select showed no dan boxes at all. It now loads the parent skin's `dan_select/dan_select.lua` first (the next match on `package.path` after this file) and adds only the clip-sampled `draw_cursor` on top; without clip data the engine's inline cursor is used as before. Future changes to the parent's dan box drawing carry over automatically. Tested: the dan ribbon, open dan box and exam panel draw again. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
GanYiZhong added 1 commit 2026-10-04 19:36:26 +02:00
dan select: extend the parent's DanSelect instead of replacing it 525a9f36ff 
The dan boxes moved to PyTaikoGreen's Scripts/dan_select/dan_select.lua, which
this skin's dan_select.lua shadowed, so no dan box was drawn. Load the parent's
script first and add only the clip-sampled cursor/arrows on top of it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GanYiZhong force-pushed fix/dan-select-parent from 3bd31f522f to 525a9f36ff 2026-10-04 19:36:26 +02:00 Compare
Yonokid added 1 commit 2026-10-05 13:46:18 +02:00
Merge branch 'main' into fix/dan-select-parent 267d0c2f3e
Yonokid merged commit dcdff8924c into main 2026-10-05 13:48:44 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GanYiZhong Yonokid
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Yonokid/YataiDONNijiiro#42