gauge: fix the fading cell gap and clear mark on this skin's grid #58

Merged
GanYiZhong merged 1 commits from GanYiZhong/YataiDONNijiiro:fix/gauge-render into main 2026-10-14 04:07:57 +02:00
Collaborator

The parent's gauge render (since its 47319061) is laid out for its own 87-cell flash gauge, and on this skin's 50 × 21 px fade-in grid it draws wrong:

  • Dark gap before the new cell. With gauge_cell_fade_in, the fading sprite is the new cell itself and the fill stops one cell short until it lands. The parent now puts the sprite at length * bw (a glow on the fill's leading edge), so the new cell faded in one cell too far right, with a dark cell before it.
  • Clear mark off the grid. The parent puts the clear mark units / 60 cells before the exact clear fraction. Here that's 3.5 px off the cell edges and the クリア frame.

Scripts/game/gauge.lua now loads the parent's gauge from its own file and replaces only render(). Its two changes:

  • with gauge_cell_fade_in, the sprite goes on cell length - 1
  • the clear mark sits gauge_clear_mark_offset cells before the fraction (skin_config, set to 1 in #57), which is the cell edge

Everything else, including the dan gauge, the fire and the result screen's draw_result, stays the parent's.

Checked with the parent's current gauge.lua on Easy and Hard (Chouchou, auto), every 100 ms over 13 s: no gap before a fading cell, and the gold zone starts at the クリア frame edge.

🤖 Generated with Claude Code

The parent's gauge render (since its 47319061) is laid out for its own 87-cell flash gauge, and on this skin's 50 × 21 px fade-in grid it draws wrong: - **Dark gap before the new cell.** With `gauge_cell_fade_in`, the fading sprite is the new cell itself and the fill stops one cell short until it lands. The parent now puts the sprite at `length * bw` (a glow on the fill's leading edge), so the new cell faded in one cell too far right, with a dark cell before it. - **Clear mark off the grid.** The parent puts the clear mark `units / 60` cells before the exact clear fraction. Here that's 3.5 px off the cell edges and the クリア frame. `Scripts/game/gauge.lua` now loads the parent's gauge from its own file and replaces only `render()`. Its two changes: - with `gauge_cell_fade_in`, the sprite goes on cell `length - 1` - the clear mark sits `gauge_clear_mark_offset` cells before the fraction (skin_config, set to 1 in #57), which is the cell edge Everything else, including the dan gauge, the fire and the result screen's `draw_result`, stays the parent's. Checked with the parent's current gauge.lua on Easy and Hard (Chouchou, auto), every 100 ms over 13 s: no gap before a fading cell, and the gold zone starts at the クリア frame edge. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
GanYiZhong added 1 commit 2026-10-14 04:07:53 +02:00
GanYiZhong merged commit 3f6124a09c into main 2026-10-14 04:07:57 +02:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Yonokid/YataiDONNijiiro#58