Notes: the cabinet's flight and big-note sparkle trail #70

2026-10-14T21:27:50+02:00

GanYiZhong commented

2026-10-14 21:27:50 +02:00

Notes fly to 魂 on the cabinet's path, and big notes leave its sparkle trail. Replaces #69, which needed engine changes: note arcs are drawn in Lua now (YataiDON 93f62e5), so this is all in the skin.

Scripts/game/note_arc.lua loads the parent's script and overrides:

Flight: the cabinet's path from the judge circle to 魂, as a cubic Bezier fitted to it (within 6 px over its 30 frames). P1 arcs up and P2 down, each with its own fit. The note reaches 魂 at frame 30 and waits there until the engine's flight ends (31 frames).
Sparks (big notes): 9 of the cabinet's 13-frame spark (game/hit_effect/firework, art on black). The first appears at frame 5, then one every 3 frames, each centred where the note was about 2 frames earlier. They are drawn at full size and additively.
The balloon keeps the parent's flight and rainbow; the cabinet's balloon flies a different path.
Big drumroll hits get sparks too, as in the parent. The script can't tell them from big notes, since both arrive as DON_L / KAT_L.

Checked in play on auto with charts of big and small don/ka, with the cabinet's path drawn over our frames: the notes and the sparks follow it. No errors in the log.

checksums.sha256 is not part of this PR.

🤖 Generated with Claude Code

Notes fly to 魂 on the cabinet's path, and big notes leave its sparkle trail. Replaces #69, which needed engine changes: note arcs are drawn in Lua now (YataiDON 93f62e5), so this is all in the skin. `Scripts/game/note_arc.lua` loads the parent's script and overrides: - **Flight:** the cabinet's path from the judge circle to 魂, as a cubic Bezier fitted to it (within 6 px over its 30 frames). P1 arcs up and P2 down, each with its own fit. The note reaches 魂 at frame 30 and waits there until the engine's flight ends (31 frames). - **Sparks** (big notes): 9 of the cabinet's 13-frame spark (`game/hit_effect/firework`, art on black). The first appears at frame 5, then one every 3 frames, each centred where the note was about 2 frames earlier. They are drawn at full size and additively. - The balloon keeps the parent's flight and rainbow; the cabinet's balloon flies a different path. - Big drumroll hits get sparks too, as in the parent. The script can't tell them from big notes, since both arrive as `DON_L` / `KAT_L`. Checked in play on auto with charts of big and small don/ka, with the cabinet's path drawn over our frames: the notes and the sparks follow it. No errors in the log. `checksums.sha256` is not part of this PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

GanYiZhong added 1 commit 2026-10-14 21:27:50 +02:00

Big notes: the cabinet's flight and sparkle trail 13eaf11c48

Scripts/game/note_arc.lua overrides the parent's note arc: notes fly the cabinet's path (a cubic Bezier fitted to it, P1 and P2 each their own) in 30 frames, and big notes leave the cabinet's 9 sparks (hit_effect/firework, additive, centred on the note). The balloon keeps the parent's flight.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

GanYiZhong referenced this pull request

2026-10-14 21:28:27 +02:00

Big notes: the cabinet's sparkle trail #69

GanYiZhong merged commit 05efb2641b into main

2026-10-14 21:54:36 +02:00

GanYiZhong referenced this issue from a commit

2026-10-14 21:55:25 +02:00

Update checksums.sha256 for #70

Sign in to join this conversation.