Dan select and dan result after the skin config move #71

Merged

GanYiZhong merged 2 commits from GanYiZhong/YataiDONNijiiro:fix/dan-select-own-base into main

2026-10-15 16:33:24 +02:00

Author	SHA1	Message	Date
TaikoZhongandClaude Opus 5.5	f9b8ddb2bf	dan result: give dan_result_song_name its outline default The table that replaced the skin_config entry has no outline, so DanResultDraw.new compared nil and the dan result screen never built. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-15 22:02:28 +08:00
TaikoZhongandClaude Opus 5.5	01e2d72afe	dan select: carry the parent's pre-2026-10-15 dan select as this skin's base Upstream removed the exam grid, value centring, rank plate and total-notes options from PyTaikoGreen's dan_select.lua and moved its numbers into the script, so this skin fell back to the parent's plain exam rows with the parent's offsets (its own SKIN table never reached the parent's local one). dan_select_base.lua is the parent's script as of 4d325135 with those options fixed to this skin's values and the dropped keys given this skin's own numbers from before the migration; dan_select.lua loads it instead of the parent's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-15 21:58:32 +08:00

Author

SHA1

Message

Date

TaikoZhongandClaude Opus 5.5

f9b8ddb2bf

dan result: give dan_result_song_name its outline default

The table that replaced the skin_config entry has no outline, so DanResultDraw.new compared nil and the dan result screen never built.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-15 22:02:28 +08:00

TaikoZhongandClaude Opus 5.5

01e2d72afe

dan select: carry the parent's pre-2026-10-15 dan select as this skin's base

Upstream removed the exam grid, value centring, rank plate and total-notes options from PyTaikoGreen's dan_select.lua and moved its numbers into the script, so this skin fell back to the parent's plain exam rows with the parent's offsets (its own SKIN table never reached the parent's local one). dan_select_base.lua is the parent's script as of 4d325135 with those options fixed to this skin's values and the dropped keys given this skin's own numbers from before the migration; dan_select.lua loads it instead of the parent's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

2026-10-15 21:58:32 +08:00