entry: pin the entry animations the Don placement is built on #46

2026-10-12T07:48:31+02:00

GanYiZhong commented

2026-10-12 07:48:31 +02:00

Nijiiro has no Graphics/entry/animation.json of its own, so it uses PyTaikoGreen's. Green recently changed its entry animations:

id 2 (drum bounce): -245 -> -340 (waypoint -295 -> -410)
id 5/6 (cloud): puff 0.75 -> 1.0 became 0.1 -> 1.2; loop 1.0 <-> 1.2 became 1.2 <-> 1.1
id 4/7/8: timings and easing
id 9 (mode select fade out): 160 -> 443 ms

Nijiiro's Scripts/entry/player.lua lands Don on DON_CY with a fixed BOUNCE_END = -367.5 (the old -245 x 1.5). With the new value, Don stops about 140 px too high after a side is picked, and the cloud is sized differently.

Change

This adds Green's previous entry/animation.json (from f7f7d5cb) unchanged, so Nijiiro's entry looks as it did before Green's change. Nijiiro's own entry scripts use ids 0-2, 4-8 and 12, and the engine uses 9-11; all of them are in it.

checksums.sha256 is not touched.

Testing

Hidden-window screen dumps of the entry screen after picking 1P: before, Don sat about 140 px above its spot; with this file, Don is back where the old build put it. No Lua errors.

Nijiiro has no `Graphics/entry/animation.json` of its own, so it uses PyTaikoGreen's. Green recently changed its entry animations: - id 2 (drum bounce): -245 -> -340 (waypoint -295 -> -410) - id 5/6 (cloud): puff 0.75 -> 1.0 became 0.1 -> 1.2; loop 1.0 <-> 1.2 became 1.2 <-> 1.1 - id 4/7/8: timings and easing - id 9 (mode select fade out): 160 -> 443 ms Nijiiro's `Scripts/entry/player.lua` lands Don on `DON_CY` with a fixed `BOUNCE_END = -367.5` (the old -245 x 1.5). With the new value, Don stops about 140 px too high after a side is picked, and the cloud is sized differently. ## Change This adds Green's previous `entry/animation.json` (from f7f7d5cb) unchanged, so Nijiiro's entry looks as it did before Green's change. Nijiiro's own entry scripts use ids 0-2, 4-8 and 12, and the engine uses 9-11; all of them are in it. `checksums.sha256` is not touched. ## Testing Hidden-window screen dumps of the entry screen after picking 1P: before, Don sat about 140 px above its spot; with this file, Don is back where the old build put it. No Lua errors.

GanYiZhong added 1 commit 2026-10-12 07:48:32 +02:00

entry: pin the entry animations the Don placement is built on dc4fc59741

Nijiiro had no Graphics/entry/animation.json of its own and took the
parent's. The parent changed its entry animations (drum bounce -245 ->
-340, cloud puff 0.75-1.0 -> 0.1-1.2, cloud loop, timings, mode-select
fade 160 -> 443 ms), but player.lua lands Don on DON_CY with a fixed
BOUNCE_END = -367.5 (the old -245 x 1.5), so after picking a side Don
now stopped ~140 px too high and the cloud was sized differently.

This adds the parent's previous entry animation.json unchanged, so
Nijiiro's entry looks as it did before the parent's change. Nijiiro's
own entry scripts and the engine's entry ids (9-11) are all in it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

GanYiZhong referenced this pull request

2026-10-12 10:08:44 +02:00

background: cabinet backdrops for the collab presets #48

GanYiZhong merged commit 4f0fb58891 into main

2026-10-13 04:52:09 +02:00

GanYiZhong commented

2026-10-13 05:04:22 +02:00

Closing: the engine now plays the 3D DON_ENTRY_IN/LOOP animations on entry (a62cfba), and the updated Green animation.json is tuned for that. Pinning the old values puts Don about 190px too low, behind the nameplate. Nijiiro works correctly with the inherited file.

GanYiZhong referenced this pull request

2026-10-13 05:05:54 +02:00

entry: drop the pinned entry animations #49

GanYiZhong commented

2026-10-13 05:05:56 +02:00

Correction to my comment above: this was already merged, so the revert is in a follow-up PR.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Yonokid/YataiDONNijiiro#46

Allow edits from maintainers